-
Notifications
You must be signed in to change notification settings - Fork 961
Jmx unit semconv alignment - Tomcat #13650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jmx unit semconv alignment - Tomcat #13650
Conversation
…nstrumentation into yaml-jmx-metrics-test
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
Tomcat metrics description md file moved to library Code review followup
.../test/java/io/opentelemetry/instrumentation/javaagent/jmx/JmxMetricInsightInstallerTest.java
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Show resolved
Hide resolved
@robsunday #13597 has been merged, so you can update with current state of |
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Show resolved
Hide resolved
…es/tomcat.yaml Co-authored-by: SylvainJuge <[email protected]>
…es/tomcat.yaml Co-authored-by: SylvainJuge <[email protected]>
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Show resolved
Hide resolved
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
tomcat.request.processing_time changed to tomcat.request.duration.total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that even if the stable dotnet runtime metrics for thread pools currently have a different approach, we should attempt to prefer the dotted namespace naming strategy, both for the thread pools and the tomcat request processor (but I agree that it might be a matter of taste here).
While the tomcat "request processor", I still think it belongs to the tomcat.request.*
namespace, so I would lean towards using tomcat.request.processor.name
instead, also this would make the tomcat.request.*
metrics share a common namespace prefix as the their metric attributes. Also, we already have a similar pattern with the jvm.memory.used metric where the attributes are jvm.memory.type
and jvm.memory.pool.name
.
So, let's keep consistency with jvm. I'll push the update next week |
Thanks a lot for your patience and efforts @robsunday !! |
No problem! @SylvainJuge - thanks for valuable comments! |
Co-authored-by: Trask Stalnaker <[email protected]>
Changes:
agent
tolibrary
folder to make it reusable in alllibrary
dependants